Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/apollo-language-server/src/__tests__/document.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,33 @@ describe("extractGraphQLDocuments", () => {
expect(documents[0].syntaxErrors.length).toBe(0);
expect(documents[0].ast.definitions.length).toBe(2);
});

it("works with a generic tagname", () => {
const textDocument = mockTextDocument(`
gql <TResponse, TOther> \`
{
hero {
...Hero_character
}
}

\${Hero.fragments.character}

{
reviews(episode: NEWHOPE) {
...ReviewList_reviews
}
}

\${ReviewList.fragments.reviews}
\`
`);
const documents = extractGraphQLDocuments(textDocument);

expect(documents.length).toEqual(1);
expect(documents[0].syntaxErrors.length).toBe(0);
expect(documents[0].ast.definitions.length).toBe(2);
});
});

describe("extracting documents from ReasonML extension nodes", () => {
Expand Down
7 changes: 5 additions & 2 deletions packages/apollo-language-server/src/document.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,14 @@ function extractGraphQLDocumentsFromJSTemplateLiterals(

const documents: GraphQLDocument[] = [];

const regExp = new RegExp(`${tagName}\\s*\`([\\s\\S]+?)\``, "gm");
const regExp = new RegExp(
`${tagName}\\s*(?:<([\\sa-zA-Z0-9_,<>]+)>)?\\s*\`([\\s\\S]+?)\``,
"gm"
);

let result;
while ((result = regExp.exec(text)) !== null) {
const contents = replacePlaceholdersWithWhiteSpace(result[1]);
const contents = replacePlaceholdersWithWhiteSpace(result[2]);
const position = document.positionAt(result.index + (tagName.length + 1));
const locationOffset: SourceLocation = {
line: position.line + 1,
Expand Down