Open
Conversation
Owner
Author
|
This this looks ready to merge; @gauravmanmode take a look? |
|
Yes, this looks good. Thanks @apoorvalal for going through this. |
Owner
Author
|
Yeah given impending deadline for GSOC i think we should merge this for now and then add it to the rest of the optimizers later [fwiw I only really use LBFGS and Frank-Wolfe regularly; for SGD type methods I just use jax/torch] |
|
Thanks. sounds good |
|
Hi @apoorvalal, this is ready from my side, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old PR from @gauravmanmode had a number of extraneous commits from merging. Git picks the relevant commits.