Skip to content

Cleaned Report callback PR.#17

Open
apoorvalal wants to merge 3 commits intomasterfrom
cleaned-pr
Open

Cleaned Report callback PR.#17
apoorvalal wants to merge 3 commits intomasterfrom
cleaned-pr

Conversation

@apoorvalal
Copy link
Owner

The old PR from @gauravmanmode had a number of extraneous commits from merging. Git picks the relevant commits.

@apoorvalal
Copy link
Owner Author

This this looks ready to merge; @gauravmanmode take a look?

@gauravmanmode
Copy link

gauravmanmode commented Aug 17, 2025

Yes, this looks good. Thanks @apoorvalal for going through this.
Maybe separately, how about doing this for all the wrappers and not only the LBFGS wrapper (could be helful for other people wrapping optimizers from this library)?

@apoorvalal
Copy link
Owner Author

Yeah given impending deadline for GSOC i think we should merge this for now and then add it to the rest of the optimizers later [fwiw I only really use LBFGS and Frank-Wolfe regularly; for SGD type methods I just use jax/torch]

@gauravmanmode
Copy link

Thanks. sounds good

@gauravmanmode
Copy link

Hi @apoorvalal, this is ready from my side,
hope we can merge this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants