Moves JSON-LD changes from old repo to new repo #5206

BoDonkey · 2025-12-09T15:53:55Z

Summary

Summarize the changes briefly, including which issue/ticket this resolves. If it closes an existing Github issue, include "Closes #[issue number]"
This PR moves the approved JSON-LD changes from the old repo to the new repo with no additional changes.

What are the specific steps to test this change?

For example:

Run the website and log in as an admin

Open a piece manager modal and select several pieces

Click the "Archive" button on the top left of the manager and confirm that it should proceed

Check that all pieces have been archived properly

What kind of change does this PR introduce?

(Check at least one)

Make sure the PR fulfills these requirements:

It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
The changelog is updated
Related documentation has been updated
Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

packages/seo/test/functional-tests.js

+      // Verify social profiles
+      assert(Array.isArray(orgSchema.sameAs), 'Organization should have sameAs array');
+      assert.strictEqual(orgSchema.sameAs.length, 2);
+      assert(orgSchema.sameAs.includes('https://twitter.com/examplecorp'));


To fix the problem, the test should check that the actual value(s) in orgSchema.sameAs array match the required host(s), not simply that the specified URL appears as a substring.
Specifically, replace orgSchema.sameAs.includes('https://twitter.com/examplecorp') with a check that at least one value in the array, when parsed as a URL, has a host that matches 'twitter.com' and a pathname that matches the expected path ('/examplecorp'). Use Node's built-in url module (or the global URL class, if available) to parse each entry before comparison.
Edit only the relevant assertion on line 118, using Array.some together with URL parsing.
Since the test uses NodeJS, we can use the global URL class without additional imports.

packages/seo/test/functional-tests.js

+      assert(Array.isArray(orgSchema.sameAs), 'Organization should have sameAs array');
+      assert.strictEqual(orgSchema.sameAs.length, 2);
+      assert(orgSchema.sameAs.includes('https://twitter.com/examplecorp'));
+      assert(orgSchema.sameAs.includes('https://linkedin.com/company/example'));


The best way to fix this problem is to avoid relying on substring (includes) checks and instead use exact string matching for URLs within the sameAs array. This involves replacing the substring check (orgSchema.sameAs.includes(...)) with a check that at least one string in the array is exactly equal to the expected URL. In JavaScript, this can be done with the Array.prototype.some() method, for example: orgSchema.sameAs.some(url => url === 'https://linkedin.com/company/example'). This ensures that only the exact expected URL passes the check, eliminating the risk of dangerous substrings. The required change is localized to line 119 in the test file, with no imports or additional definitions required.

packages/seo/test/functional-tests.js

+        llmsTxt.includes('A test site demonstrating llms.txt'),
+        'Should include site description'
+      );
+      assert(llmsTxt.includes('https://example.com'), 'Should include base URL');


To fix the problem, we should avoid substring matching when verifying that a particular canonical URL appears in the llms.txt content in a security-sensitive or correctness-sensitive way. Instead, we should parse the output: extract lines that contain URLs (e.g. by matching lines containing https://), and properly parse the URLs using Node's url or URL class to confirm that 'example.com' is indeed the host of a listed URL. For this test, the optimal fix is to look for a line/lines in llms.txt containing a URL, extract the URL using a regex, and parse it to check that the host is example.com. All required code edits should be limited to the single test block containing line 463. An extra import is not strictly required, as Node.js has a built-in URL class.

ValJed

There are too many unwanted changes in the package.json

ValJed · 2025-12-09T16:33:16Z

packages/seo/package.json

+    "url": "git+https://github.com/apostrophecms/seo.git"
  },
-  "homepage": "https://github.com/apostrophecms/apostrophe/tree/main/packages/seo",
+  "homepage": "https://github.com/apostrophecms/seo#readme",


You should reference inside the monorepo since the seo module will die.

Changed, along with the "repository"

ValJed · 2025-12-09T16:33:53Z

packages/seo/package.json

    "lodash": "^4.17.21"
  },
  "devDependencies": {
-    "eslint": "^9.39.1",


you should keep eslint dep

Not sure how that got removed. Added back.

ValJed · 2025-12-09T16:34:35Z

packages/seo/package.json

+    "@apostrophecms/blog": "^1.0.6",
+    "@apostrophecms/seo": "file:.",
+    "apostrophe": "^4.24.0",
+    "eslint-config-apostrophe": "^5.0.0",


"eslint-config-apostrophe": "workspace:^",

ValJed · 2025-12-09T16:35:00Z

packages/seo/package.json

-    "eslint-config-apostrophe": "workspace:*"
+    "@apostrophecms/blog": "^1.0.6",
+    "@apostrophecms/seo": "file:.",
+    "apostrophe": "^4.24.0",


"apostrophe": "workspace:^",

ValJed · 2025-12-09T16:35:19Z

packages/seo/package.json

-    "eslint": "^9.39.1",
-    "eslint-config-apostrophe": "workspace:*"
+    "@apostrophecms/blog": "^1.0.6",
+    "@apostrophecms/seo": "file:.",


Do we need that?

Yes, for the functional tests

ValJed · 2025-12-09T16:35:46Z

packages/seo/package.json

  "devDependencies": {
-    "eslint": "^9.39.1",
-    "eslint-config-apostrophe": "workspace:*"
+    "@apostrophecms/blog": "^1.0.6",


"@apostrophecms/blog": "workspace:^",

boutell

LGTM, I must admit there's too much here to go line by line.

boutell

OK it sounds like this is what I reviewed before, just migrating.

boutell · 2026-01-05T14:00:01Z

packages/seo/.changeset/config.json

@@ -0,0 +1,11 @@
+{


You should run pnpm changeset in the repo root, not in individual package folders. Note the existing root .changeset folder. The individual changeset files know which package they impact.

boutell@Mac:~/apostrophecms/apostrophe$ ls .changeset/ config.json modern-radios-attack.md nice-peas-care.md README.md soft-laws-doubt.md boutell@Mac:~/apostrophecms/apostrophe$ ff changeset ./.changeset/modern-radios-attack.md ./.changeset/config.json ./.changeset/nice-peas-care.md ./.changeset/README.md ./.changeset/soft-laws-doubt.md

Left company

Moves JSON-LD changes from old repo to new repo

b70351d

BoDonkey requested a review from boutell December 9, 2025 15:53

github-advanced-security bot found potential problems Dec 9, 2025

View reviewed changes

ValJed previously requested changes Dec 9, 2025

View reviewed changes

BoDonkey added 2 commits December 9, 2025 14:55

package.json changes for monorepo

495cf02

Adds back the seo module for tests

f6c632b

BoDonkey requested a review from ValJed December 9, 2025 20:17

Blog to workspace

cf1e39e

boutell approved these changes Dec 12, 2025

View reviewed changes

boutell previously approved these changes Dec 12, 2025

View reviewed changes

Merge branch 'main' into seo-json-ld-update

fa70862

BoDonkey dismissed boutell’s stale review via fa70862 December 16, 2025 20:49

BoDonkey requested a review from boutell December 16, 2025 20:50

boutell previously approved these changes Dec 17, 2025

View reviewed changes

Revert CHANGELOG

caac480

BoDonkey dismissed boutell’s stale review via caac480 January 2, 2026 18:38

Adds changeset to repo and changes for current code updates

1f24978

BoDonkey requested a review from boutell January 2, 2026 19:07

boutell requested changes Jan 5, 2026

View reviewed changes

BoDonkey added 2 commits January 5, 2026 14:37

remove changeset from repo

7073cdc

Add proper changeset

895e153

BoDonkey requested a review from boutell January 5, 2026 19:39

Fixes patch level

f232c5c

boutell previously approved these changes Jan 8, 2026

View reviewed changes

Merge branch 'main' into seo-json-ld-update

fac6da3

boutell dismissed their stale review via fac6da3 January 8, 2026 15:35

boutell self-requested a review January 8, 2026 15:36

boutell approved these changes Jan 8, 2026

View reviewed changes

BoDonkey removed the request for review from ValJed January 8, 2026 15:42

BoDonkey merged commit 9cfd745 into main Jan 8, 2026
13 of 14 checks passed

BoDonkey deleted the seo-json-ld-update branch January 8, 2026 15:43

@@ -115,7 +115,17 @@
                   // Verify social profiles
                   assert(Array.isArray(orgSchema.sameAs), 'Organization should have sameAs array');
                   assert.strictEqual(orgSchema.sameAs.length, 2);
-                  assert(orgSchema.sameAs.includes('https://twitter.com/examplecorp'));
+                  assert(
+                    orgSchema.sameAs.some(u => {
+                      try {
+                        const { host, pathname } = new URL(u);
+                        return host === 'twitter.com' && pathname === '/examplecorp';
+                      } catch (e) {
+                        return false;
+                      }
+                    }),
+                    'Organization should have a Twitter "sameAs" with correct host and pathname'
+                  );
                   assert(orgSchema.sameAs.includes('https://linkedin.com/company/example'));
                 });

@@ -460,7 +460,16 @@
                     llmsTxt.includes('A test site demonstrating llms.txt'),
                     'Should include site description'
                   );
-                  assert(llmsTxt.includes('https://example.com'), 'Should include base URL');
+                  // Look for a line with a URL, extract it, and check host
+                  const urlMatches = llmsTxt.match(/https?:\/\/[^\s)]+/g) || [];
+                  const hasExampleCom = urlMatches.some(u => {
+                    try {
+                      return (new URL(u)).hostname === 'example.com';
+                    } catch (e) {
+                      return false;
+                    }
+                  });
+                  assert(hasExampleCom, 'Should include base URL with host example.com');
                   assert(
                     llmsTxt.includes('## AI Training Policy') ||
                     llmsTxt.includes('AI Training'),

Moves JSON-LD changes from old repo to new repo #5206

Moves JSON-LD changes from old repo to new repo #5206

Uh oh!

Conversation

BoDonkey commented Dec 9, 2025

Summary

What are the specific steps to test this change?

What kind of change does this PR introduce?

Make sure the PR fulfills these requirements:

Uh oh!

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

ValJed left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

boutell left a comment

Choose a reason for hiding this comment

Uh oh!

boutell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants