-
Notifications
You must be signed in to change notification settings - Fork 622
styles feature #5252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ETLaurent
wants to merge
98
commits into
main
Choose a base branch
from
feature-styles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
styles feature #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRO-8599: process styles cascade
…he into feature-styles
PRO-8598: Validate and extend presets
PRO-8593: object types support for styles
PRO-8615: Add utility CSS
* remove palette migrations * add warning * mock * Revert "mock" This reverts commit 496feca. * only warn if palette exists * remove duplicated tips --------- Co-authored-by: ETLaurent <[email protected]>
PRO-8585: Support complex conditions
* Add core widget styles, add missing tests * Simplify alignment preset
* fix properties keys order to make valid css * adapt tests * fix * add changelog --------- Co-authored-by: ETLaurent <[email protected]>
…yle editing when no styles
Pro 8609 apply layout style
* wip use helpers for columns * renders columns style when logout / preview * removes logs * moves vue styles logic into composable * uses new styles composable in rich text editor component * removes logs, style tag before div * adds AposGridColumn * uses AposGrid Column in grid layout for real content columns * improves grid column component for content * wip reworks grid manager / layout * tets styles for layout column * moves recompute styles logic into composable and use it for columns too * removes comments * do not parse object if no styles fields at all * uses method instead of computed to render content items elements * handles livepreview styles for contextual styles widgets (rich text / columns) * removes comments, test styles * fixes style rendered twice in column widget nunjucks template
Co-authored-by: ETLaurent <[email protected]>
* astro: add widget styles feature --------- Co-authored-by: ETLaurent <[email protected]>
Contributor
Author
Co-authored-by: ETLaurent <[email protected]>
…the text (#5259) * part 1: widget default data should include schema fields even for contextual widgets * part 2: don't discard style changes when we emit rich text changes
* Refactor postcss plugin, export vanilla JS function for browser/nodejs usage * Typo - the vanilla function returns a string, not an object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: