support additional slack channels for openshift-upgrade-watcher via cluster labels#5280
Open
maorfr wants to merge 1 commit intoapp-sre:masterfrom
Open
support additional slack channels for openshift-upgrade-watcher via cluster labels#5280maorfr wants to merge 1 commit intoapp-sre:masterfrom
maorfr wants to merge 1 commit intoapp-sre:masterfrom
Conversation
Member
|
Please add some tests 🙇 |
maorfr
force-pushed
the
openshift-upgrade-watcher-notifications
branch
2 times, most recently
from
567d23b to
4c01d3a
Compare
maorfr
force-pushed
the
openshift-upgrade-watcher-notifications
branch
from
4c01d3a to
e0433cb
Compare
hemslo
reviewed
Nov 11, 2025
| state_key=state_key, | ||
| state_value=None, | ||
| ) | ||
| slack.channel = default_channel |
Contributor
There was a problem hiding this comment.
There is another notification in notify_cluster_new_version, should it support multiple channels too? Then this channel change should be handled in one level above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds support to send cluster upgrade notifications to additional slack channels by adding the following label to a cluster file: