Refactor QuayApi to extend ApiBase#5353
Merged
esron merged 8 commits intoapp-sre:masterfrom Jan 13, 2026
Merged
Conversation
hemslo
reviewed
Jan 8, 2026
esron
force-pushed
the
refactor-quay-api-to-base-api-use
branch
2 times, most recently
from
6f4bd84 to
2c2e4c5
Compare
esron
force-pushed
the
refactor-quay-api-to-base-api-use
branch
from
bf7e0c3 to
9ba4d8a
Compare
esron
force-pushed
the
refactor-quay-api-to-base-api-use
branch
from
9ba4d8a to
340f8d6
Compare
Contributor
Author
|
I am reverting this while I investigate the dry-run error during promotion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5184
Related to APPSRE-11883
Refactored
QuayApito extendApiBasefromrest_api_base.py, replacing direct requests calls withApiBasemethods (_get,_post,_put,_delete) for consistency with other API clients likeGlitchtipClient. UpdatedQuayApi.__init__to accept full URLs (e.g., http://localhost:12345) for testing while preserving backward compatibility with hostname-only inputs (e.g., quay.io).Migrated tests from the
responseslibrary topytest-httpserverto align with theGlitchtiptest pattern and ensure compatibility withrequests.Sessionused byApiBase. All existing error handling and method signatures remain unchanged, maintaining full backward compatibility with existingQuayApiusage throughout the codebase.