increase timeout for secret cache ttl#5418
Closed
jonmosco wants to merge 1 commit intoapp-sre:masterfrom
Closed
Conversation
hemslo
reviewed
Feb 11, 2026
chassing
reviewed
Feb 11, 2026
| value = self.secret_backends[secret.url].read(secret) | ||
| # TODO : TTL from config | ||
| self.cache.set(cache_key, value, 5) | ||
| self.cache.set(cache_key, value, 300) |
Member
There was a problem hiding this comment.
Don't increase this TTL! TBH, I don't trust Redis/ElastiCache enough to store our secrets permanently! These 5 seconds are for performance reasons.
Contributor
There was a problem hiding this comment.
link to #5332 (comment) to be covered by in memory cache for the whole request lifecycle
Contributor
Author
|
Ok, will close this and investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase secret cache TTL from 5 seconds to 5 minutes. This will hopefully reduce vault secret reads.