Skip to content

feat(onboarding): add launch at login step and make start/help targets#443

Open
guicheffer wants to merge 2 commits intomainfrom
feat/70-launch-at-login-step
Open

feat(onboarding): add launch at login step and make start/help targets#443
guicheffer wants to merge 2 commits intomainfrom
feat/70-launch-at-login-step

Conversation

@guicheffer
Copy link
Contributor

@guicheffer guicheffer commented Mar 21, 2026

Summary

Adds a new onboarding step (step 7 of 9) that asks the user whether to launch Vox at login. Also adds make start as an alias for make dev and a make help target listing all available targets.

Changes

  • New LaunchAtLoginStep component (step 7 of 9) — radio choice defaulting to current config value (launchAtLogin), which now defaults to false instead of isProduction
  • launchAtLogin default changed from isProduction to false in createDefaultConfig(); the actual OS call in ipc.ts is already guarded by app.isPackaged, so there is no dev-environment impact
  • All 10 locale files updated with translated keys for the new step (onboarding.launchAtLogin.*)
  • Step totals updated from 8→9 across all existing onboarding step components
  • OnboardingOverlay step map, nav guard, and analytics step index updated accordingly
  • OnboardingStep type and MAX_STEP constant extended to include step 8
  • make start added as alias for make dev; make help added listing all targets
  • CONTRIBUTING.md and README.md updated with new make targets

Test plan

  • npm run typecheck passes
  • npm run lint passes
  • npm test passes
  • New step render test (renders launch at login step at step 7)
  • Dots count updated to >= 9
  • Analytics step updated to completed_step: 8
  • Config default test (launchAtLogin defaults to false)
  • Pre-existing done step test updated to step 8
  • Launch at login step reflects current config value (radio pre-selected when launchAtLogin: true)

Screenshots

image

Code standards

  • i18n — All user-facing strings use the translation system. New keys added to all locale files.
  • Dev Panel — No new internal state requiring Dev Panel exposure.
  • CSS — CSS Modules with CSS custom properties. No hardcoded color/spacing values.
  • SVGs — SVG assets in separate files, not inlined in TSX.
  • Accessibility — Radio inputs are keyboard-navigable with appropriate labels.

Closes #70

@guicheffer guicheffer added feature New feature implementation ui/ux User interface and experience labels Mar 21, 2026
@guicheffer guicheffer self-assigned this Mar 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2026

CI Summary

Check Status
Typecheck ✅ Passed
Lint ✅ Passed
Lint CSS ✅ Passed
Design Tokens ✅ Passed
Test ✅ Passed
Build ✅ Passed

Run #1095

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2026

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ JSON jsonlint 10 0 0 0.13s
✅ JSON npm-package-json-lint yes no no 2.74s
✅ JSON prettier 10 0 0 0.84s
✅ JSON v8r 10 0 0 4.13s
✅ MARKDOWN markdownlint 2 0 0 1.47s
⚠️ MARKDOWN markdown-table-formatter 2 1 0 0.37s
✅ REPOSITORY checkov yes no no 25.42s
✅ REPOSITORY devskim yes no no 2.25s
✅ REPOSITORY dustilock yes no no 1.33s
✅ REPOSITORY gitleaks yes no no 1.73s
✅ REPOSITORY git_diff yes no no 0.31s
✅ REPOSITORY grype yes no no 47.75s
✅ REPOSITORY kics yes no no 2.74s
✅ REPOSITORY kingfisher yes no no 5.73s
✅ REPOSITORY secretlint yes no no 5.26s
✅ REPOSITORY syft yes no no 2.61s
✅ REPOSITORY trivy yes no no 9.88s
✅ REPOSITORY trivy-sbom yes no no 3.55s
✅ REPOSITORY trufflehog yes no no 4.34s

Detailed Issues

⚠️ MARKDOWN / markdown-table-formatter - 1 error
1 files contain markdown tables to format:
- README.md

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature implementation ui/ux User interface and experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant