feat(onboarding): add launch at login step and make start/help targets#443
Open
guicheffer wants to merge 2 commits intomainfrom
Open
feat(onboarding): add launch at login step and make start/help targets#443guicheffer wants to merge 2 commits intomainfrom
guicheffer wants to merge 2 commits intomainfrom
Conversation
Contributor
CI Summary
|
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ JSON | jsonlint | 10 | 0 | 0 | 0.13s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 2.74s | |
| ✅ JSON | prettier | 10 | 0 | 0 | 0.84s | |
| ✅ JSON | v8r | 10 | 0 | 0 | 4.13s | |
| ✅ MARKDOWN | markdownlint | 2 | 0 | 0 | 1.47s | |
| markdown-table-formatter | 2 | 1 | 0 | 0.37s | ||
| ✅ REPOSITORY | checkov | yes | no | no | 25.42s | |
| ✅ REPOSITORY | devskim | yes | no | no | 2.25s | |
| ✅ REPOSITORY | dustilock | yes | no | no | 1.33s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 1.73s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.31s | |
| ✅ REPOSITORY | grype | yes | no | no | 47.75s | |
| ✅ REPOSITORY | kics | yes | no | no | 2.74s | |
| ✅ REPOSITORY | kingfisher | yes | no | no | 5.73s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 5.26s | |
| ✅ REPOSITORY | syft | yes | no | no | 2.61s | |
| ✅ REPOSITORY | trivy | yes | no | no | 9.88s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 3.55s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 4.34s |
Detailed Issues
⚠️ MARKDOWN / markdown-table-formatter - 1 error
1 files contain markdown tables to format:
- README.md
See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Show us your support by starring ⭐ the repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new onboarding step (step 7 of 9) that asks the user whether to launch Vox at login. Also adds
make startas an alias formake devand amake helptarget listing all available targets.Changes
LaunchAtLoginStepcomponent (step 7 of 9) — radio choice defaulting to current config value (launchAtLogin), which now defaults tofalseinstead ofisProductionlaunchAtLogindefault changed fromisProductiontofalseincreateDefaultConfig(); the actual OS call inipc.tsis already guarded byapp.isPackaged, so there is no dev-environment impactonboarding.launchAtLogin.*)OnboardingOverlaystep map, nav guard, and analytics step index updated accordinglyOnboardingSteptype andMAX_STEPconstant extended to include step 8make startadded as alias formake dev;make helpadded listing all targetsCONTRIBUTING.mdandREADME.mdupdated with new make targetsTest plan
npm run typecheckpassesnpm run lintpassesnpm testpassesrenders launch at login step at step 7)>= 9completed_step: 8launchAtLogindefaults tofalse)launchAtLogin: true)Screenshots
Code standards
Dev Panel — No new internal state requiring Dev Panel exposure.Closes #70