Skip to content

fix/feat: (UI improvements) LLM banner, shortcuts delay, bug when saving, tab constants & Dictionary shortcut#448

Open
guicheffer wants to merge 1 commit intomainfrom
fix/llm-banner-hud-retry
Open

fix/feat: (UI improvements) LLM banner, shortcuts delay, bug when saving, tab constants & Dictionary shortcut#448
guicheffer wants to merge 1 commit intomainfrom
fix/llm-banner-hud-retry

Conversation

@guicheffer
Copy link
Contributor

@guicheffer guicheffer commented Mar 22, 2026

Summary

  • LLM config banner: small purple badge in Titlebar when AI Enhancement is enabled but not configured/tested — hides when on the AI Enhancement tab, navigates to it on click
  • Pipeline rebuild after LLM failure: after onLlmFailed, pipeline is now rebuilt via setImmediate(() => setupPipeline()) so next recording uses NoopProvider (no spurious "enhancing" HUD state)
  • Retry button blocked: retry in Transcriptions panel is disabled when entry failed due to LLM and AI Enhancement is still not configured
  • Shortcut delay: reduced post-save isInitializing lock from 1500ms → 300ms (first press after saving config now works)
  • SaveToast stuck: toast no longer stays visible forever when hideToast() is called externally — syncs visible to false during render when show is false
  • Tab constants: all hardcoded tab IDs ("general", "whisper", "llm", etc.) moved to src/shared/tabs.ts as Tabs.GENERAL, Tabs.SPEECH, etc.
  • Dictionary shortcut: added Dictionary (⌘D) to the app menu under File, alongside Transcriptions (⌘T)
  • i18n: ui.llmConfigBanner key added to all 10 locale files
  • btw, included the "First time user" as part of the dev panels options

Test plan

  • npm run typecheck passes
  • npm run lint passes
  • npm run lint:css passes
  • npm run check:tokens passes
  • npx vitest run passes (584 tests, 54 files)
  • Manually tested (describe how)

Code standards

  • i18n — All user-facing strings use the translation system. New keys added to all locale files.
  • Dev Panel — New internal state is exposed in the Dev Panel where useful for debugging.
  • CSS — CSS Modules with CSS custom properties. No hardcoded color/spacing values.
  • SVGs — SVG assets in separate files, not inlined in TSX.
  • Accessibility — Interactive elements are keyboard-navigable with appropriate ARIA attributes.

Screenshots

also included a warning:
image

🤖 Generated with Claude Code

@guicheffer guicheffer added bug Something isn't working feature New feature implementation labels Mar 22, 2026
@guicheffer guicheffer self-assigned this Mar 22, 2026
@guicheffer guicheffer added enhancement New feature or request ui/ux User interface and experience electron labels Mar 22, 2026
@guicheffer guicheffer changed the title fix/feat: LLM banner, shortcuts delay, SaveToast bug, tab constants & Dictionary shortcut fix/feat: (UI improvements) LLM banner, shortcuts delay, bug when saving, tab constants & Dictionary shortcut Mar 22, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2026

CI Summary

Check Status
Typecheck ✅ Passed
Lint ✅ Passed
Lint CSS ✅ Passed
Design Tokens ✅ Passed
Test ✅ Passed
Build ✅ Passed

Run #1110

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ JSON jsonlint 10 0 0 0.14s
✅ JSON npm-package-json-lint yes no no 1.87s
✅ JSON prettier 10 0 0 5.49s
✅ JSON v8r 10 0 0 4.86s
✅ REPOSITORY checkov yes no no 28.03s
✅ REPOSITORY devskim yes no no 2.88s
✅ REPOSITORY dustilock yes no no 0.96s
✅ REPOSITORY gitleaks yes no no 1.97s
✅ REPOSITORY git_diff yes no no 0.05s
✅ REPOSITORY grype yes no no 47.37s
✅ REPOSITORY kics yes no no 2.73s
✅ REPOSITORY kingfisher yes no no 5.01s
✅ REPOSITORY secretlint yes no no 6.14s
✅ REPOSITORY syft yes no no 2.3s
✅ REPOSITORY trivy yes no no 20.13s
✅ REPOSITORY trivy-sbom yes no no 2.74s
✅ REPOSITORY trufflehog yes no no 3.78s

See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@guicheffer guicheffer force-pushed the fix/llm-banner-hud-retry branch from d34e7b7 to 3c21918 Compare March 22, 2026 17:26
…tab constants, Dictionary shortcut

Co-Authored-By: João Prado <joao.prado@hellofresh.com>
@guicheffer guicheffer force-pushed the fix/llm-banner-hud-retry branch from 3c21918 to 6a714cf Compare March 22, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working electron enhancement New feature or request feature New feature implementation ui/ux User interface and experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant