-
Notifications
You must be signed in to change notification settings - Fork 15
Migrated breaking changes for use with Hotchocolate 14 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QueryResult is now OperationResult
Renamed QueryResultExtensions to OperationResultExtensions
Fixed simple spelling mistakes: AssertSuceessResult is now AssertSuccessResult formattedMessagePlaceholerValues is now formattedMessagePlaceholderValues FieldSkipValidationPredecate is now FieldSkipValidationPredicate
m4tchl0ck
suggested changes
Nov 12, 2024
m4tchl0ck
reviewed
Nov 12, 2024
vvoldsund
approved these changes
Nov 13, 2024
m4tchl0ck
approved these changes
Nov 13, 2024
|
Awesome work! I would love to see it accepted soon as it's the only thing blocking us from a HC14 migration |
|
@sergeyshaykhullin can you merge it? |
Closed
Member
|
Thank you @d-lundy, @m4tchl0ck and @sergeyshaykhullin for your valuable contribution to the project! Your effort and dedication help strengthen the community! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryResult is now OperationResult