remove minimum interval requirements#31
Merged
mcorbin merged 1 commit intoappclacks:masterfrom Oct 31, 2025
Merged
Conversation
Collaborator
|
Hello, I'm OK to remove the condition. Thank you for your contribution :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was wondering if there was a strong reasoning behind the minimum interval requirement of 2 seconds. We actually patched it and tried it in production, and co-jointly with anycastd were able to reach downtimes <300ms. It seems like a "don't try to hurt yourself with this tool" that is a little bit too restrictive.
The conditions could also be kept, but with something like 50ms minimum interval. The performance impact was quite linear from what we observed, and it should be up to users to choose this trade-off.
Thanks for this very cool project !