ahres-2168 Remove invalid options for combobox component

[sidiinia]

Fix: Ensure selected options array does not contain undefined values

[kermitapp]

Jira Issue: https://appfolio.atlassian.net/browse/ahres-2168

[mdalpozzo]

you could write this a bit more efficiently with reduce if you wanted, but also fine as is

.reduce<Option<T>[]>((acc, v) => {
      const found = options.find((option) => equal(option.value, v));
      if (found) acc.push(found);
      return acc;
    }, [])

[DistractedPrimate]

Open question (non blocking): Is there a way that we can somehow log when the combobox is receiving invalid parameters? Would be nice to know when we are passing bad params in a way that doesn't crash pages.

[JeremyRH]

Open question (non blocking): Is there a way that we can somehow log when the combobox is receiving invalid parameters? Would be nice to know when we are passing bad params in a way that doesn't crash pages.

@DistractedPrimate TypeScript should handle this. Logs sometimes get ignored.

[JeremyRH]

@sidiinia Your commit messages must follow conventional commits. E.g. fix(Combobox): Ensure selected options array does not contain undefined values

[github-actions]

Released prerelease version 8.14.3-ahres-2169-remove-invalid-options-for-combobox-c739139.0.
You may now run npm install @appfolio/react-gears@ahres-2169-remove-invalid-options-for-combobox