Skip to content

[FEE-927] add offset on Tooltip popover content #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brian-Holland merged 1 commit into from
Feb 4, 2025
Merged

[FEE-927] add offset on Tooltip popover content #1264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const Tooltip: FC<TooltipProps> = ({
isOpen = defaultProps.isOpen,
fade = defaultProps.fade,
target,
placement = 'top',
...props
}) => {
const [open, setOpen] = useState(isOpen);
Expand All @@ -17,8 +18,26 @@ const Tooltip: FC<TooltipProps> = ({
setOpen(!open);
}, [open]);

//adds offset for the popper placement base on placement prop
const offsets: Record<string, [number, number]> = {
top: [0, 5],
bottom: [0, 5],
left: [0, 8],
right: [0, 8],
};
Comment on lines +22 to +27
Copy link
Contributor Author

@Brian-Holland Brian-Holland Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offsets are uneven here to account for the vertical space around text that isn't there horizontally.


const offset = offsets[placement];

return (
<InnerTooltip isOpen={open} toggle={handleToggle} fade={fade} target={target} {...props} />
<InnerTooltip
isOpen={open}
toggle={handleToggle}
fade={fade}
target={target}
placement={placement}
offset={offset}
{...props}
/>
);
};

Expand Down
Loading