This repository was archived by the owner on Mar 23, 2020. It is now read-only.
Fixed path of the example app - UICatalog.app #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '../../apps/UICatalog/build/release-iphonesimulator', | ||
| 'UICatalog.app') | ||
| app = os.path.abspath(app) | ||
| app = os.path.abspath('../../apps/UICatalog/build/release-iphonesimulator/UICatalog.app') |
Contributor
There was a problem hiding this comment.
this means that the path will be different based on the working directory. the existing strategy is to make it absolute, based on the location of this file. I think we probably still need it the way it is. You could join the last two lines, though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as my previous pull request on ios_simple.py : #80
The path to the UICatalog.app was previously derived by concatenating a ‘system path' + 'name_of_the_app’. I suppose this might have been done since they had too many example apps in the directory.
Removed that concatenation step.
All we need is a direct path to the UICatalog app.