-
-
Notifications
You must be signed in to change notification settings - Fork 196
fix: handle orientation command properly for ios #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the orientation handling for iOS by adding explicit orientation commands in both iOS and Android test cases, and updating the driver to route orientation commands appropriately.
- Added tests for setting and asserting orientations for iOS and Android.
- Updated the driver to handle iOS orientation commands using proxyCommand and to distinguish between orientation-related commands in the executeCommand method.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| example/ruby/example_sample2_ios.rb | Added orientation setting tests for iOS. |
| example/ruby/example_sample2.rb | Added orientation setting tests for Android. |
| driver/lib/driver.ts | Updated get/setOrientation methods and command handling. |
|
@KazuCocoa How to adopt your fix? Below maven dependency is being used in my pom. |
|
This is appium flutter driver fix. Please use appium flutter driver 2.15.2. This is not client side code. (I guess you're saying client side stuff) |
|
@KazuCocoa So I am using Appium Driver as base driver.. |
|
Sorry, I'm confused. Your original ticket had:
so you use appium flutter driver, correct? This is not client-side talk. |
|
My ticket Let me try once more to explain. Though I can see AndroidDriver and IOSDriver both extend AppiumDriver which have ScreenRotation method available. |
|
Could you make sure you don't talk about classes in https://github.com/appium/java-client? This is not client side stuff. So in case your Then, what appium server and drivers do you use in your framework? If this appium flutter driver was hidden in the framework from your perspective, the necessary update is in the framework side, how to manage appium servers/drivers. |
iOS hasn't been handled properly yet
Closes #793