Skip to content

Conversation

@eglitise
Copy link
Collaborator

@eglitise eglitise commented Jan 7, 2026

This is an update to the format of the exported .appiumsession file:

  • Add the name property. In the future this will allow importing multiple sessions at once, similarly to gestures.
  • Remove the serverType and visibleProviders properties, as these can be assembled from the server property
  • Only keep the current server details in the server property, plus the advanced property
  • Update the version property to 2.0
  • Add tests for parsing the updated file format

Also, the name of the exported file is now based on the saved session name, instead of the server type, which should allow to distinguish them more easily.

Important to note that importing of version 1.0 session files is still supported. However, older Inspector version will not be able to import version 2.0 session files.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the .appiumsession file format from version 1.0 to 2.0, streamlining the structure while maintaining backward compatibility. The new format adds a session name property for future multi-session imports, removes redundant properties, and only stores the active server configuration.

Key changes:

  • New v2.0 file format with name property and simplified server structure (single server type instead of all server types)
  • Backward compatibility for importing v1.0 files maintained
  • Enhanced test coverage with version-specific test suites and edge case validation

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
app/common/renderer/constants/session-builder.js Adds version constant '2.0' and default session name constant
app/common/renderer/utils/file-handling.js Implements version-specific parsing functions for v1 and v2 formats with separate validation logic
app/common/renderer/actions/SessionBuilder.js Updates import/export logic to handle v2 format conversion and generates filename from session name
app/common/renderer/reducers/SessionBuilder.js Merges visibleProviders from imported sessions with existing state
test/unit/utils-file-handling.spec.js Adds comprehensive test suite organized by version with validation edge cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the dependencies Dependency updates, removals or additions label Jan 8, 2026
@eglitise eglitise requested a review from Copilot January 8, 2026 07:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eglitise eglitise merged commit 39300d3 into appium:main Jan 8, 2026
8 checks passed
@eglitise eglitise deleted the update-sessionfile branch January 8, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Dependency updates, removals or additions enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants