-
-
Notifications
You must be signed in to change notification settings - Fork 361
feat: update .appiumsession file format #2535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the .appiumsession file format from version 1.0 to 2.0, streamlining the structure while maintaining backward compatibility. The new format adds a session name property for future multi-session imports, removes redundant properties, and only stores the active server configuration.
Key changes:
- New v2.0 file format with
nameproperty and simplifiedserverstructure (single server type instead of all server types) - Backward compatibility for importing v1.0 files maintained
- Enhanced test coverage with version-specific test suites and edge case validation
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| app/common/renderer/constants/session-builder.js | Adds version constant '2.0' and default session name constant |
| app/common/renderer/utils/file-handling.js | Implements version-specific parsing functions for v1 and v2 formats with separate validation logic |
| app/common/renderer/actions/SessionBuilder.js | Updates import/export logic to handle v2 format conversion and generates filename from session name |
| app/common/renderer/reducers/SessionBuilder.js | Merges visibleProviders from imported sessions with existing state |
| test/unit/utils-file-handling.spec.js | Adds comprehensive test suite organized by version with validation edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This is an update to the format of the exported
.appiumsessionfile:nameproperty. In the future this will allow importing multiple sessions at once, similarly to gestures.serverTypeandvisibleProvidersproperties, as these can be assembled from theserverpropertyserverproperty, plus theadvancedpropertyversionproperty to2.0Also, the name of the exported file is now based on the saved session name, instead of the server type, which should allow to distinguish them more easily.
Important to note that importing of version
1.0session files is still supported. However, older Inspector version will not be able to import version2.0session files.