feat: build atoms with current trunk in selneium #384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
commented
Jun 25, 2024
| Z.o=function(a,b){var c=function(){var d=Z.s(b,a,9);return d?d.singleNodeValue||null:b.selectSingleNode?(d=w(b),d.setProperty&&d.setProperty("SelectionLanguage","XPath"),b.selectSingleNode(a)):null}();null===c||Z.K(c,a);return c}; | ||
| Z.j=function(a,b){var c=function(){var d=Z.s(b,a,7);if(d){for(var e=d.snapshotLength,f=[],g=0;g<e;++g)f.push(d.snapshotItem(g));return f}return b.selectNodes?(d=w(b),d.setProperty&&d.setProperty("SelectionLanguage","XPath"),b.selectNodes(a)):[]}();p(c,function(d){Z.K(d,a)});return c};var dd={className:wc,"class name":wc,css:xc,"css selector":xc,relative:Y,id:$c,linkText:X,"link text":X,name:{o:function(a,b){b=x(v(b),"*",null,b);return wa(b,function(c){return Ec(c,"name")==a})},j:function(a,b){b=x(v(b),"*",null,b);return ra(b,function(c){return Ec(c,"name")==a})}},partialLinkText:ad,"partial link text":ad,tagName:ed,"tag name":ed,xpath:Z};function cd(a){for(var b in a)if(a.hasOwnProperty(b))return b;return null} | ||
| function bd(a,b){var c=cd(a);if(c){var d=dd[c];if(d&&ha(d.o))return d.o(a[c],b||ic.document)}throw new P(61,"Unsupported locator strategy: "+c);};da("_",function(a,b,c,d){var e=bd,f={};f[a]=b;try{var g;d?g=vc(d.WINDOW):g=window;var h=g;var n;c?n=vc(c.ELEMENT,h.document):n=h.document;var u=e(f,n);var l={status:0,value:sc(u)}}catch(z){l={status:null!==z&&"code"in z?z.code:13,value:{message:z.message}}}return rc(l)});; return this._.apply(null,arguments);}).apply(window, arguments);} | ||
| function bd(a,b){var c=cd(a);if(c){var d=dd[c];if(d&&ha(d.o))return d.o(a[c],b||ic.document)}throw new P(61,"Unsupported locator strategy: "+c);};da("_",function(a,b,c,d){var e=bd,f={};f[a]=b;try{var g;d?g=vc(d.WINDOW):g=window;var h=g;var n;c?n=vc(c.ELEMENT,h.document):n=h.document;var u=e(f,n);var l={status:0,value:sc(u)}}catch(z){l={status:null!==z&&"code"in z?z.code:13,value:{message:z.message}}}return rc(l)});; return this._.apply(null,arguments);}).apply({navigator:typeof window!='undefined'?window.navigator:null,document:typeof window!='undefined'?window.document:null}, arguments);} |
There was a problem hiding this comment.
Or I wondered if we only should modify this file only or can be removed. SeleniumHQ/selenium#12549.
This is a new file added in Selnium 4.11 based atoms in https://github.com/appium/appium-remote-debugger/pull/268/files#diff-d78e75f95db0fc8e13d20f695ad56d938f636bbce81324754640d2a54d657688
There was a problem hiding this comment.
No, this was more complicated.
appium/appium#18951
appium/appium-xcuitest-driver#1884
SeleniumHQ/selenium#12549
for example when I reverted only this file, a click action caused:
Selenium::WebDriver::Error::UnknownError: An unknown server-side error occurred while processing the command. Original error: Remote debugger error with code 'undefined': TypeError: undefined is not an object (evaluating 'ia.JSON.stringify')
from UnknownError: An unknown server-side error occurred while processing the command. Original error: Remote debugger error with code 'undefined': TypeError: undefined is not an object (evaluating 'ia.JSON.stringify')
Perhaps we should learn more about atoms code..
There was a problem hiding this comment.
rules_closure-0.12.0 had no diff.
There was a problem hiding this comment.
I saw SeleniumHQ/selenium#14890, so they will probably use newer rules. Then, will something change help us potentially...?
|
-> #412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#383
Not for this, but I saw updated atoms affected JS handling for a website, such as failing to load content after some actions in the atoms. Perhaps we also need to update possible atoms issues as well. (not as this PR)