Skip to content

Conversation

@KazuCocoa
Copy link
Member

List of changes

Part of #990 for iOS

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change that adds functionality or value)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • Test fix (non-breaking change that improves test stability or correctness)

Documentation

  • Have you proposed a file change/ PR with Appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests for your changes? (required for Bugfix, New feature, or Test fix)

Details

Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@github-actions github-actions bot added the CI label Jan 4, 2026
[Test]
public void ScrollActionTestCase()
{
if (Env.IsCiEnvironment())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KazuCocoa, Wouldn't it be cleaner approach to skip the tests in the tests steps of the yaml file?

Copy link
Member Author

@KazuCocoa KazuCocoa Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current way is to help grep with Env.IsCiEnvironment() to find skipped test cases easily, so we can move to CLI arguments later if it is more dotnet's preference way as a followup PR

@KazuCocoa KazuCocoa marked this pull request as ready for review January 5, 2026 00:12
@KazuCocoa
Copy link
Member Author

Merging to run android/ios tests on GHA at least

@KazuCocoa KazuCocoa merged commit 9efe516 into main Jan 5, 2026
12 checks passed
@KazuCocoa KazuCocoa deleted the gha-function-ios branch January 5, 2026 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants