fix: avoid using system default locale #2352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
mykola-mokhnach
approved these changes
Oct 3, 2025
|
Please address checkstyle issues |
For example, if the system default locale is Turkish ("tr_TR"), then
`ClipboardContentType.PLAINTEXT` argument gets converted to "plaıntext", not "plaintext".
1. Replace `toLowerCase()` -> `toLowerCase(ROOT)`
2. Replace `toUpperCase()` -> `toUpperCase(ROOT)`
"ROOT" is a specific locale that at least works well for latin letters (that are used in content types, enum names etc.)
asolntsev
force-pushed
the
fix/avoid-using-system-locale
branch
from
af152e3 to
2378184
Compare
valfirst
approved these changes
Oct 3, 2025
saikrishna321
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if the system default locale is Turkish ("tr_TR"), then
ClipboardContentType.PLAINTEXTargument gets converted to "plaıntext", not "plaintext".Change list
toLowerCase()->toLowerCase(ROOT)toUpperCase()->toUpperCase(ROOT)"ROOT" is a specific locale that at least works well for latin letters (that are used in content types, enum names etc.)
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply