feat: add support for descendant and ancestor flutter locators #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudharsan-selvaraj
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
saikrishna321
requested changes
Oct 9, 2025
|
@sudharsan-selvaraj Please fix the CI for checkstyle |
|
I'm currently looking into the test failure for ios and will address it. |
valfirst
reviewed
Oct 9, 2025
| } | ||
|
|
||
| static String formatLocator(FlutterBy of, FlutterBy matching, Map<String, Object> properties) { | ||
| Map<String, Object> locator = new HashMap<>(); |
There was a problem hiding this comment.
can we also use Map.of like above?
mykola-mokhnach
approved these changes
Oct 9, 2025
valfirst
approved these changes
Oct 9, 2025
saikrishna321
approved these changes
Oct 9, 2025
SrinivasanTarget
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Added new locator strategies
AppiumBy.flutterDescendantandAppiumBy.flutterAncestorto support flutter's descendant and ancestor finders.Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that apply