Skip to content

feat: add timeout for server stop as method param #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat: add timeout for server stop as method param #1030

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e168586
add timeout for process termination
LykashevichAndrei Sep 24, 2024
1a26a13
Merge branch 'master' into master
KazuCocoa Oct 2, 2024
d586360
chore: update type
KazuCocoa Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions appium/webdriver/appium_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,20 +222,23 @@ def start(self, **kwargs: Any) -> sp.Popen:
raise AppiumServiceError(error_msg)
return self._process

def stop(self) -> bool:
def stop(self, timeout: int = 5) -> bool:
"""Stops Appium service if it is running.

The call will be ignored if the service is not running
or has been already stopped.

Args:
timeout: timeout for process termination.

Returns:
`True` if the service was running before being stopped
"""
is_terminated = False
if self.is_running:
assert self._process
self._process.terminate()
self._process.communicate(timeout=5)
self._process.communicate(timeout=timeout)
is_terminated = True
self._process = None
self._cmd = None
Expand Down
Loading