Skip to content

feat: Added typing for AppiumBy #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2024
Merged

feat: Added typing for AppiumBy #1071

merged 4 commits into from
Nov 29, 2024

Conversation

@Brijeshkrishna
Copy link
Contributor

@Brijeshkrishna Brijeshkrishna commented Nov 28, 2024

Adding typing annotations for AppiumBy types

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 28, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

mykola-mokhnach
mykola-mokhnach reviewed Nov 28, 2024
View reviewed changes
mykola-mokhnach
mykola-mokhnach reviewed Nov 28, 2024
View reviewed changes
@Brijeshkrishna Brijeshkrishna marked this pull request as draft November 28, 2024 19:21
@Brijeshkrishna Brijeshkrishna marked this pull request as ready for review November 28, 2024 19:42
@Brijeshkrishna Brijeshkrishna changed the title feat: Added typing for AppiumBy types feat: Added typing for AppiumBy Nov 29, 2024
@mykola-mokhnach
Copy link
Contributor

mykola-mokhnach commented Nov 29, 2024

Please make sure tests are happy: https://github.com/appium/python-client/actions/runs/12079337810/job/33689980005?pr=1071

@KazuCocoa KazuCocoa merged commit 00e9a6e into appium:master Nov 29, 2024
10 checks passed
@KazuCocoa KazuCocoa added size:XS contribution size: XS size:S contribution size: S and removed size:XS contribution size: XS labels Dec 2, 2024
@jlipps
Copy link
Member

jlipps commented Jan 8, 2025

Hi @Brijeshkrishna, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

@Brijeshkrishna
Copy link
Contributor Author

Brijeshkrishna commented Jan 10, 2025

Hi @Brijeshkrishna, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you!

@jlipps @KazuCocoa
This is my account https://opencollective.com/brijeshkrishna

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@mykola-mokhnach mykola-mokhnach mykola-mokhnach approved these changes

Assignees

No one assigned

Labels

size:S contribution size: S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Brijeshkrishna @mykola-mokhnach @jlipps @KazuCocoa