chore: use uv for version #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| current = io.open(os.path.join(os.path.dirname('__file__'), 'appium', 'version.py'), encoding='utf-8').read().rstrip() | ||
| print('The current version is {}, type a new one'.format(MESSAGE_YELLOW.format(current))) | ||
| return current | ||
| os.system('uv version') |
Contributor
There was a problem hiding this comment.
this method does not return anything, but looks like it should
Member
Author
There was a problem hiding this comment.
The original one was also to print the version in the stdout, so return value is not matter
Contributor
There was a problem hiding this comment.
then the method name is confusing as get prefix implicitly assumes it must return something
mykola-mokhnach
approved these changes
Aug 7, 2025
Member
Author
|
-> I think we can use #1161 after initial release with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uv versioncan be used to manage versions. The getting version code has references, so this PR keeps the version file to returnimportlib.metadata.version('Appium-Python-Client'). It is available since Python v3.8, and we require Python v3.9+ so should be ok.