Skip to content

refactor: _adjust_image_payload #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2025
Merged

refactor: _adjust_image_payload #1172

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62cc0bf
refact: _adjust_image_payload
wooyoung294 Sep 10, 2025
5f153e3
style: move import binascii
wooyoung294 Sep 10, 2025
9c46a64
refactor: raise helpful ValueError on UnicodeDecodeError
wooyoung294 Sep 11, 2025
b7a51e4
refactor: add from e
wooyoung294 Sep 11, 2025
2482d3c
style: ruff formatting
wooyoung294 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion appium/webdriver/extensions/images_comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@

from typing import Any, Dict, Union

import base64

import binascii

from appium.protocols.webdriver.can_execute_commands import CanExecuteCommands

from ..mobilecommand import MobileCommand as Command
Expand Down Expand Up @@ -147,4 +151,13 @@ def _add_commands(self) -> None:


def _adjust_image_payload(payload: Base64Payload) -> str:
return payload if isinstance(payload, str) else payload.decode('utf-8')
if isinstance(payload, str):
return payload
try:
b64_str = payload.decode('ascii')
base64.b64decode(payload,validate=True)
return b64_str
except (UnicodeDecodeError, binascii.Error):
return base64.b64encode(payload).decode('ascii')


Loading