Upgrade to python 3.12 in pre-commit test.#1360
Open
raytomato wants to merge 4 commits intoapple:mainfrom
Open
Upgrade to python 3.12 in pre-commit test.#1360raytomato wants to merge 4 commits intoapple:mainfrom
raytomato wants to merge 4 commits intoapple:mainfrom
Conversation
raytomato
force-pushed
the
cliu74/python312
branch
2 times, most recently
from
80749a6 to
63e1145
Compare
raytomato
force-pushed
the
cliu74/python312
branch
from
63e1145 to
a655d8e
Compare
wangkuiyi
reviewed
Feb 10, 2026
.github/workflows/pre-commit.yml
Outdated
| - run: pip install uv | ||
| # TODO(markblee): Remove gcp,vertexai_tensorboard from CI. (needed by pytype) | ||
| - run: pip install '.[core,audio,orbax,dev,gcp,vertexai_tensorboard,open_api]' | ||
| - run: uv pip install --system '.[core,audio,orbax,dev,gcp,vertexai_tensorboard,open_api]' |
Contributor
There was a problem hiding this comment.
We should create a uv venv following https://github.com/apple/axlearn/blob/main/docs/01-start.md#installation before running uv pip install. In this way, I expect that we will not need --system.
Contributor
Author
There was a problem hiding this comment.
Yeah, @changlan is aware of it.
Let's continue the discussion in the existing thread I just sent you.
This copy is more for testing purpose, showing that the fix could work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update pre-commit setup following axlearn Python upgrade.