Pass root directory URL as env variable so that plugins can use it#1322
Closed
JaewonHur wants to merge 1 commit intoapple:mainfrom
Closed
Pass root directory URL as env variable so that plugins can use it#1322JaewonHur wants to merge 1 commit intoapple:mainfrom
JaewonHur wants to merge 1 commit intoapple:mainfrom
Conversation
realrajaryan
approved these changes
Mar 17, 2026
jglogan
requested changes
Mar 17, 2026
Contributor
jglogan
left a comment
There was a problem hiding this comment.
Using request changes to prevent merge for one sec - why can't the plugin root be determined by convention as ${APP_ROOT}/plugin-state? What is the use case for needing to locate it in some arbitrary location?
Contributor
Author
|
I guess the reason I pass it as env variable is that we get I was not sure it should be always the default path. |
Contributor
|
I think we only need environment variables for our base directories:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
PluginStateRootclass so that a plugin can figure out its root URL where the plugin specific data should be stored.Type of Change
Motivation and Context
[Why is this change needed?]
Testing