Skip to content

Remove obsolete disableAllocator from network delete path #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manojmahapatra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove obsolete disableAllocator from network delete path #1332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Sources/Services/ContainerAPIService/Server/Networks/NetworksService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,6 @@ public actor NetworksService {
)
}

// disable the allocator so nothing else can attach
// TODO: remove this from the network helper later, not necesssary now that withContainerList is here
guard try await serviceState.client.disableAllocator() else {
throw ContainerizationError(.invalidState, message: "cannot delete subnet \(id) because the IP allocator cannot be disabled with active containers")
}

// start network deletion, this is the last place we'll want to throw
do {
try await self.deregisterService(configuration: netConfig)
Expand Down