Skip to content

define JSONDecoder() outside of for loop in load() #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katiewasnothere merged 1 commit into from
Jun 12, 2025
Merged

define JSONDecoder() outside of for loop in load() #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/ContainerPersistence/EntityStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,13 @@ public actor FilesystemEntityStore<T>: EntityStore where T: Codable & Identifiab
private static func load(path: URL, log: Logger) throws -> Index {
let directories = try FileManager.default.contentsOfDirectory(at: path, includingPropertiesForKeys: nil)
var index: FilesystemEntityStore<T>.Index = Index()
let decoder = JSONDecoder()

for entityUrl in directories {
do {
let metadataUrl = entityUrl.appendingPathComponent(metadataFilename)
let data = try Data(contentsOf: metadataUrl)
let entity = try JSONDecoder().decode(T.self, from: data)
let entity = try decoder.decode(T.self, from: data)
index[entity.id] = entity
} catch {
log.warning(
Expand Down