Skip to content

Update kernel install UX#19

Closed
adityaramani wants to merge 18 commits intomainfrom
users/a_ramani/install-ux
Closed

Update kernel install UX#19
adityaramani wants to merge 18 commits intomainfrom
users/a_ramani/install-ux

Conversation

@adityaramani
Copy link
Contributor

@adityaramani adityaramani commented Jun 5, 2025

This change updates the UX when we install required dependencies at first launch

Fresh install - respond y to prompt

➜ bin/container system start
Verifying apiserver is running...
Installing base container filesystem...
No default kernel configured.
Install the recommended default kernel from [https://github.com/kata-containers/kata-containers/releases/download/3.17.0/kata-static-3.17.0-arm64.tar.xz]? [Y/n]: y
Installing kernel...

Fresh install - respond n to prompt and then run the provided command

➜ bin/container system start
Verifying apiserver is running...
No default kernel configured.
Install the recommended default kernel from [https://github.com/kata-containers/kata-containers/releases/download/3.17.0/kata-static-3.17.0-arm64.tar.xz]? [Y/n]: n
Please use the `container system kernel set --recommended` command to configure the default kernel

➜ bin/container system kernel set --recommended
Installing the recommended kernel from https://github.com/kata-containers/kata-containers/releases/download/3.17.0/kata-static-3.17.0-arm64.tar.xz...

Fresh install - respond n to prompt and then run a container

➜ bin/container system start
Verifying apiserver is running...
Installing base container filesystem...
No default kernel configured.
Install the recommended default kernel from [https://github.com/kata-containers/kata-containers/releases/download/3.17.0/kata-static-3.17.0-arm64.tar.xz]? [Y/n]: n
Please use the `container system kernel set --recommended` command to configure the default kernel

➜ bin/container run alpine uname
Error: notFound: "Default kernel not configured for architecture arm64. Please use the `container system kernel set` command to configure it

katiewasnothere and others added 18 commits June 3, 2025 15:23
@katiewasnothere
Initial commit
d5f30b8
@katiewasnothere
Update alpine images used (#1)
6603f79 
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
@katiewasnothere
Update broken test (#2)
018ec34 
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
@katiewasnothere @adityaramani @dkovba
Cherry pick additional changes (#3)
bb2330e 
* Format the codebase (#50)

Signed-off-by: Aditya Ramani <a_ramani@apple.com>

* Update packages before going public (#48)

---------

Signed-off-by: Aditya Ramani <a_ramani@apple.com>
Co-authored-by: Aditya Ramani <a_ramani@apple.com>
Co-authored-by: dkovba <dkovba@apple.com>
@jglogan
Addresses remaining TODO items in user documentation. (#4)
8771a1b 
* Addresses remaining TODO items in user documentation.

* Add functional model diagram.
@adityaramani
Register existing runtime plugin launch units on boot (#5)
258e44e
@adityaramani
Selectively uncompress kernel binary from archive (#7)
3c0608d
@dkovba
Update swift-docc-plugin to fix a non-sendable warning (#8)
bbeb6f1 
This PR resolves warnings:
```
…/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Preview/Symbolic Links/SwiftDocCPluginUtilities/BuildGraph/DocumentationBuildGraph.swift:106:17: warning: capture of non-sendable type 'Target.Type' in an isolated closure
104 |             // Copy the closure and the target into a block operation object
105 |             let new = BlockOperation { [work, task] in
106 |                 work(task)
    |                 `- warning: capture of non-sendable type 'Target.Type' in an isolated closure
107 |             }
108 |             operationsByID[task.id] = new

…/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Preview/Symbolic Links/SwiftDocCPluginUtilities/BuildGraph/DocumentationBuildGraph.swift:105:41: warning: capture of non-sendable type 'Target.Type' in an isolated closure
103 |             }
104 |             // Copy the closure and the target into a block operation object
105 |             let new = BlockOperation { [work, task] in
    |                                         `- warning: capture of non-sendable type 'Target.Type' in an isolated closure
106 |                 work(task)
107 |             }
```
@dkovba
Ignore API docs that are for local preview only (#10)
f2ba695 
The added lines mirror the ones in containerization.
@adityaramani
Create RequestScheme type to handle registry interactions (#6)
85c9a5b 
Its a bit weird to have to pass `--http` when pulling / pushing images
if we are trying to do so from a local registry

This PR adds a `RequestScheme` enum type which tries to detect if the
connection to the registry should be over http or https. This auto
detection is the default behavior and can be overridden by passing the
`--scheme http/https` flag to the `run` ,`pull`, `push` `login` and
`registry default` command

The auto detection works by looking at the hostname / IP. HTTP is used
in the following cases
 - If the hostname starts with `localhost` or  is `127.x.x.x`
 - if the host looks like an IP from the private address space
 - If the host ends with the current default dns domain name

Also in this PR:
- Removing some used CLI flag groups and TODOs
- Better error messages when registry credentials are not found for a
host

Signed-off-by: Aditya Ramani <a_ramani@apple.com>
@katiewasnothere
Publish docs github action (#9)
a0b4b83 
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
@jglogan
Fix typo in default subnet setting. (#12)
d6b4692
@katiewasnothere
Add token to allow deploying github pages (#13)
6686f05 
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
@katiewasnothere
Fix typo in release branch name (#14)
ed4a4cb 
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
@adityaramani
Cleanup output from --version (#16)
a756184 
The output now looks like the following

#### When build against a tagged HEAD in `RELEASE` mode
```
container --version
container CLI version 0.0.2 (build: release, commit: ed4a4cb)
```
@dkovba
Clear a line with spaces to prevent a race between stderr and `stdo…
23b2680 
…ut` (#18)

This PR resolves a race with `\u{001B}[2K`, but not with `\r`, which
will be addressed in a separate PR by moving progress updates to
`stdout`. Please test it in a small window in your terminal application
on the `users/a_ramani/install-ux` branch using commands:
```
bin/container system stop
make cleancontent
bin/container system start
```
You should see the prompt:
> Install the recommended default kernel from
[https://github.com/kata-containers/kata-containers/releases/download/3.17.0/kata-static-3.17.0-arm64.tar.xz]?
[Y/n]:
@heckj
README updates (#17)
95cef58 
- break up readme into separate files
- rework hedaings on Code of Conduct
- Add a CONTRIBUTORS.txt
@adityaramani
Update kernel install UX
b41cf15 
Signed-off-by: Aditya Ramani <a_ramani@apple.com>
@mavenugo
Copy link
Contributor

mavenugo commented Jun 5, 2025

am sure it is a typo ... but I see that the following text is missing in the "Fresh install - respond n to prompt and then run the provided command" section :

Installing base container filesystem...

@adityaramani
Copy link
Contributor Author

adityaramani commented Jun 6, 2025

Yes you are right - it was a typo.

am sure it is a typo ... but I see that the following text is missing in the "Fresh install - respond n to prompt and then run the provided command" section :

Installing base container filesystem...

@adityaramani
Copy link
Contributor Author

adityaramani commented Jun 6, 2025

Reopened : #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adityaramani @mavenugo @katiewasnothere @jglogan @dkovba @heckj