Use bookworm in tutorial, disable console block copy.#39
Conversation
|
Please refer to #40 where I used the <pre> tag to replace the code blocks to avoid the copy-to-clipboard... I still see the copy-to-clipboard option with console tag. |
jglogan
force-pushed
the
users/jglogan/shellsession-console
branch
from
3ffe99e to
6711c23
Compare
jglogan
changed the title
There was a problem hiding this comment.
@joshelman I dont see wget as well in the web-test image.
docs/tutorial.md
Outdated
There was a problem hiding this comment.
when I tried the web-test image, I dont see wget either.
jglogan
changed the title
- Switched to use bookworm Python image as curl is not in slim. - Use `pre` tags for console blocks. We lose syntax highlighting, but get rid of the copy button. - Fix dockerfile tag in tutorial. - Fix GitHub typo in README.
jglogan
force-pushed
the
users/jglogan/shellsession-console
branch
from
7d6fca7 to
d066e29
Compare
|
...testing now... |
| To validate your published image, remove your existing web server image, and then run using the remote image: | ||
| To validate your published image, stop your current web server container, remove the image that you built, and then run using the remote image: | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
This should be changed to <pre> as well. since "registry.example.com" and "fido" are all sample ones, there is no use for the users to copy them in clipboard. Also, this is a multi line command... copy them and pasting will result in failure and that isnt useful either.
There was a problem hiding this comment.
copy/paste multiple lines should work as long as there's no interactive input on any command
There was a problem hiding this comment.
It seems odd to me to use console format for something that's not a terminal session - prompts, input, and output.
Users may want to copy/paste and then edit the command line, as opposed to typing everything in. zsh and just about any modern shell allows editing multi-line commands.
|
|
||
| Your web server is accessible from other containers as well as from your host. Launch a second container using your `web-test` image, and this time, specify a `curl` command to retrieve the `index.html` content from the first container. | ||
| Your web server is accessible from other containers as well as from your host. Launch a second container using your `web-test` image, and this time, specify a `wget` command to retrieve the `index.html` content from the first container. | ||
|
|
There was a problem hiding this comment.
I think it is useful to have another bash with just container run -it --rm web-test curl http://192.168.64.3 for easy copy-paste for the user. (we have it just below for test domain below).
- Switched to use bookworm Python image as `curl` is not in slim. - Use `pre` tags for console blocks. We lose syntax highlighting, but get rid of the copy button. - Fix `dockerfile` tag in tutorial. - Fix GitHub typo in README.
4 participants
curlis not in slim.pretags for console blocks. We lose syntax highlighting, but get rid of the copy button.dockerfiletag in tutorial.