EXT4: Adjustments to file names and visibilities#112
Merged
adityaramani merged 1 commit intoapple:mainfrom Jun 13, 2025
Merged
Conversation
Member
dcantah
commented
Jun 13, 2025
dcantah
commented
- FileTimestamps constructor that actually let you provide values was not public, so it wasn't possible to pass in values other than nil. This change makes the other constructor and the underlying fields public.
- Rename EXT4+Format to EXT4+Formatter
- Rename EXT4+Export to EXT4Reader+Export
- Make the superblock publicly accessible in the reader like the docs for the product states.
Member
Author
|
Will fix formatting shortly |
- FileTimestamps constructor that actually let you provide values was not public, so it wasn't possible to pass in values other than nil. This change makes the other constructor and the underlying fields public. - Rename EXT4+Format to EXT4+Formatter - Rename EXT4+Export to EXT4Reader+Export - Make the superblock publicly accessible in the reader like the docs for the product states.
dcantah
force-pushed
the
ext4-public-the-world-but-not-really
branch
from
5d45d78 to
4af13eb
Compare
adityaramani
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.