Merged
Conversation
Make sure we always set TERM=xterm for containers that ask for a tty.
adityaramani
approved these changes
Jun 18, 2025
adityaramani
pushed a commit
to adityaramani/containerization
that referenced
this pull request
Jun 20, 2025
Make sure we always set TERM for containers that ask for a tty. Right now this handling was spread around in a bunch of spots, but I'd wager setting it for the client on the host via LinuxContainer/Process is more sane and already what we do for a lot of the other fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we always set TERM for containers that ask for a tty. Right now this handling was spread around in a bunch of spots, but I'd wager setting it for the client on the host via LinuxContainer/Process is more sane and already what we do for a lot of the other fields.