fix: quote inputs and improve shell conditionals for safety#68
Merged
wlan0 merged 1 commit intoapple:mainfrom Jun 10, 2025
Merged
fix: quote inputs and improve shell conditionals for safety#68wlan0 merged 1 commit intoapple:mainfrom
wlan0 merged 1 commit intoapple:mainfrom
Conversation
katiewasnothere
approved these changes
Jun 10, 2025
Contributor
katiewasnothere
left a comment
There was a problem hiding this comment.
Thanks for the fix! :) will merge as soon as the CI completes
wlan0
approved these changes
Jun 10, 2025
Contributor
|
We just enabled signed commits as a requirement. Can you setup signing for your commit? I'm using SSH based signing and it is quick to get setup. See Github's docs here: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification |
b5a4b12 to
167cb39
Compare
167cb39 to
dd070b4
Compare
Contributor
Author
|
I've signed the commit using SSH as requested. Please let me know if there's anything else to fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves safety and consistency of the GitHub Actions workflow (build-test-images.yml) file by:
This helps prevent bugs in shell parsing, especially with empty or misinterpreted input values.
@katiewasnothere @wlan0