Skip to content

fix: quote inputs and improve shell conditionals for safety#68

Merged
wlan0 merged 1 commit intoapple:mainfrom
Thedarkmatter10:fix/input-quoting
Jun 10, 2025
Merged

fix: quote inputs and improve shell conditionals for safety#68
wlan0 merged 1 commit intoapple:mainfrom
Thedarkmatter10:fix/input-quoting

Conversation

@Thedarkmatter10
Copy link
Contributor

This PR improves safety and consistency of the GitHub Actions workflow (build-test-images.yml) file by:

  • Using [[ ... ]] instead of [ ... ] for conditionals.
  • Adding double quotes around inputs and refs to avoid evaluation issues.

This helps prevent bugs in shell parsing, especially with empty or misinterpreted input values.

@katiewasnothere @wlan0

@dcantah dcantah requested review from katiewasnothere and wlan0 June 10, 2025 06:41
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! :) will merge as soon as the CI completes

@crosbymichael
Copy link
Contributor

We just enabled signed commits as a requirement. Can you setup signing for your commit? I'm using SSH based signing and it is quick to get setup.

See Github's docs here: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification

@Thedarkmatter10
Copy link
Contributor Author

I've signed the commit using SSH as requested. Please let me know if there's anything else to fix
@crosbymichael

@wlan0 wlan0 merged commit 5240d36 into apple:main Jun 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants