Skip to content

Conversation

ajzeigert
Copy link

Adds Librewolf to web-browser-extension-distribution-information.json

Overall Checklist

@JaminenB
Copy link

JaminenB commented Jul 8, 2025

@rmondello Can this be reviewed to support the Librewolf browser?

3
]
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a whitespace error here.

"Mac": {
"bundle_identifier": "org.mozilla.librewolf",
"code_signing_identifier": "librewolf",
"code_signing_team_identifier": "not set",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that this browser doesn’t have a code signing team identifier means that adding it to this list won’t actually make it work with the iCloud Passwords extension. Apps need to be signed.

@ajzeigert
Copy link
Author

That makes sense. It seems like the app is being signed? But maybe this field is just not set? I'm not super familiar with how code signing works, but here's the output of codesign -dvvv /Applications/LibreWolf.app:

$ codesign -dvvv /Applications/LibreWolf.app
Executable=/Applications/LibreWolf.app/Contents/MacOS/librewolf
Identifier=librewolf
Format=app bundle with Mach-O thin (arm64)
CodeDirectory v=20400 size=552 flags=0x20002(adhoc,linker-signed) hashes=14+0 location=embedded
Hash type=sha256 size=32
CandidateCDHash sha256=f458e182af0da6c2cff9d197a27f1aad17a72671
CandidateCDHashFull sha256=f458e182af0da6c2cff9d197a27f1aad17a726713c06da7e98b17702ea7e62d8
Hash choices=sha256
CMSDigest=f458e182af0da6c2cff9d197a27f1aad17a726713c06da7e98b17702ea7e62d8
CMSDigestType=2
CDHash=f458e182af0da6c2cff9d197a27f1aad17a72671
Signature=adhoc
Info.plist=not bound
TeamIdentifier=not set
Sealed Resources=none
Internal requirements=none

I can also inquire on the official LibreWolf channel how the app is being signed, if at all, for the macOS distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants