Add autocomplete support for 'outer' keyword#148
Open
melnikalex wants to merge 1 commit intoapple:mainfrom
Open
Add autocomplete support for 'outer' keyword#148melnikalex wants to merge 1 commit intoapple:mainfrom
melnikalex wants to merge 1 commit intoapple:mainfrom
Conversation
Implements type computation for the 'outer' keyword, allowing autocomplete to work when accessing members of the enclosing object scope. Changes: - Add ComputeOuterType.kt to compute the type of outer references - Update ComputeExprType.kt to use computeOuterType() for outer expressions - Add test case for outer completion in CompletionTest.kt The implementation walks up the PSI tree to find the immediate enclosing object, then continues to the next enclosing object and returns its type, enabling proper member resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements autocomplete support for the
outerkeyword in the pkl-intellij plugin.Changes
ComputeOuterType.kt- Computes the type ofouterreferences by walking up the PSI tree to find the enclosing object scopeComputeExprType.kt- Updated to usecomputeOuterType()instead of returningType.UnknownforPklOuterExprtest complete from outerinCompletionTest.ktImplementation Details
The
computeOuterType()function follows the same pattern ascomputeThisType():This enables autocomplete to work when typing
outer.inside nested object expressions, showing members of the enclosing scope.Testing
outer.shows correct members (methods and properties) from the enclosing objectExample Usage