-
Notifications
You must be signed in to change notification settings - Fork 353
feat: add pkl bom module #1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pkl bom module #1390
Conversation
eddie4941
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be tested by first building the bom pom.xml:
./gradlew :pkl-bom:clean :pkl-bom:generatePomFileForLibraryPublication
and then checking the list of dependencies via:
grep '<dependency>' -A 4 pkl-bom/build/publications/library/pom-default.xml
which should produce a list of all the included dependencies like:
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-cli</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-codegen-java</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-codegen-kotlin</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-commons</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-commons-cli</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-commons-test</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-config-java</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-config-java-all</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-config-kotlin</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-core</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-doc</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-executor</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-formatter</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-gradle</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-parser</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-server</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
<dependency>
<groupId>org.pkl-lang</groupId>
<artifactId>pkl-tools</artifactId>
<version>0.31.0-SNAPSHOT</version>
</dependency>
bioball
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, generally looks good! Left a few comments to address.
This adds a module that will publish a bom file that will help consumers align versions for all pkl artifacts using the single bom.
Both the library and bom publishing conventions were duplicating some of the steps in each file. This moves the common code to a central location to avoid duplication.
Remove internal modules.
60b54c7 to
f35d522
Compare
bioball
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds a module that will publish a bom file that will help consumers
align versions for all pkl artifacts using the single bom.