Skip to content

Conversation

@eddie4941
Copy link
Contributor

This adds a module that will publish a bom file that will help consumers
align versions for all pkl artifacts using the single bom.

Copy link
Contributor Author

@eddie4941 eddie4941 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be tested by first building the bom pom.xml:

./gradlew :pkl-bom:clean :pkl-bom:generatePomFileForLibraryPublication

and then checking the list of dependencies via:

 grep '<dependency>' -A 4 pkl-bom/build/publications/library/pom-default.xml

which should produce a list of all the included dependencies like:

   <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-cli</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-codegen-java</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-codegen-kotlin</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-commons</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-commons-cli</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-commons-test</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-config-java</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-config-java-all</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-config-kotlin</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-core</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-doc</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-executor</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-formatter</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-gradle</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-parser</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-server</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>org.pkl-lang</groupId>
        <artifactId>pkl-tools</artifactId>
        <version>0.31.0-SNAPSHOT</version>
      </dependency>

Copy link
Member

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, generally looks good! Left a few comments to address.

This adds a module that will publish a bom file that will help consumers
align versions for all pkl artifacts using the single bom.
Both the library and bom publishing conventions were duplicating some of
the steps in each file. This moves the common code to a central location
to avoid duplication.
Remove internal modules.
Copy link
Member

@bioball bioball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bioball bioball merged commit 6cd03c7 into apple:main Jan 5, 2026
17 checks passed
@eddie4941 eddie4941 deleted the feat-pkl-bom branch January 5, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants