Improve output when validation fails #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also revamps the file structure for validators.
natecook1000
force-pushed
the
validation-tweaks
branch
from
466d04a to
3fbbcac
Compare
With backtrace support built into command-line Swift, calling `fatalError` for configuration/validation errors isn't very effective, since the error messages get hidden by the backtrace. This switches to simply printing the validation message to stderr and exiting with a failing error code, which possibly should have always been the behavior.
natecook1000
force-pushed
the
validation-tweaks
branch
from
3fbbcac to
e0e2942
Compare
|
The cmake CI is very helpful! |
|
@swift-ci Please test |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches to simply printing the validation message to stderr and exiting with a failing error code, which possibly should have always been the behavior. This also revamps the file structure for validators.
Checklist