Skip to content

Implement AsyncSequence.enumerated() #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adam-fowler
Copy link
Contributor

Pretty much the same as Sequence.enumerated but for AsyncSequence.

eg Translates ["a", "b", "c"] to [(0,"a"), (1, "b"), (2, "c")]

@FranzBusch
Copy link
Member

Thanks for opening this @adam-fowler! Definitely a needed AsyncSequence. We are still finalising the 1.0.0 release. I will mark this as a 1.1.0 candidate

@FranzBusch FranzBusch added the v1.1 Post-1.0 work label Apr 5, 2023
macserv pushed a commit to macserv/advent-of-code that referenced this pull request Dec 22, 2023
@phausler
Copy link
Member

I know this has been a very long while since this was posted; however since we are at development for 1.1 this is a really useful algorithm for composing buffer dropping detection and other such things. I would love to run this in the near future - if you are still interested in pushing this forward I would like to see if this is something you would still like to do. Alternatively I can update this and drive it forward if not (still of course giving credit for the original drafts)

@adam-fowler
Copy link
Contributor Author

I know this has been a very long while since this was posted; however since we are at development for 1.1 this is a really useful algorithm for composing buffer dropping detection and other such things. I would love to run this in the near future - if you are still interested in pushing this forward I would like to see if this is something you would still like to do. Alternatively I can update this and drive it forward if not (still of course giving credit for the original drafts)

Hi, yes I'd be happy to push this forward. I'm out for the next two weeks but can respond to any PR requests after that.

@phausler
Copy link
Member

That probably aligns just right with some of the other algorithms. Let me know when you feel things are ready to go.

I think there are a few implementation details that need to be addressed but the major issue is getting a proposal written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.1 Post-1.0 work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants