Skip to content

Fix slow failing test #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Fix slow failing test #57

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5cd43eb
Add more logging to help debug a test failure
czechboy0 Jan 24, 2025
3dac5ef
Enable more logging
czechboy0 Jan 24, 2025
bff1f23
Try to reduce the count to avoid timeouts
czechboy0 Jan 24, 2025
2968a48
Undo hardcoding the verbose flag
czechboy0 Jan 28, 2025
47011b5
Format fix
czechboy0 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions Tests/AsyncDNSResolverTests/c-ares/CAresDNSResolverTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ final class CAresDNSResolverTests: XCTestCase {
options.servers = servers

self.resolver = try! CAresDNSResolver(options: options)
self.verbose = ProcessInfo.processInfo.environment["VERBOSE_TESTS"] == "true"
self.verbose = true // TODO: Undo this before merging!!!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

}

override func tearDown() {
Expand Down Expand Up @@ -122,11 +122,19 @@ final class CAresDNSResolverTests: XCTestCase {
}

func test_concurrency() async throws {
let verbose = self.verbose

func run(
_ name: String,
times: Int = 100,
_ query: @Sendable @escaping (_ index: Int) async throws -> Void
) async throws {
let start = Date.now
defer {
if verbose {
print("Test of \(name) took \(Int64(start.timeIntervalSinceNow * -1000)) ms.")
}
}
do {
try await withThrowingTaskGroup(of: Void.self) { group in
for i in 1...times {
Expand All @@ -137,13 +145,14 @@ final class CAresDNSResolverTests: XCTestCase {
for try await _ in group {}
}
} catch {
print("Test of \(name) is throwing an error.")
if verbose {
print("Test of \(name) is throwing an error.")
}
throw error
}
}

let resolver = self.resolver!
let verbose = self.verbose
try await run("queryA") { i in
let reply = try await resolver.queryA(name: "apple.com")
if verbose {
Expand Down
Loading