Default to enabled observability #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Swift Log/Swift Metrics integration should be enabled by default. And the operator can always pass in a no-op log/metrics backend if they want to discard it.
This is important when Configuration is used as a transitive dependency, as there the operator wouldn't have a way to enable observability from this library unless the direct dependency that pulled in Configuration was cooperative.
Modifications
Enabled logging/metrics by default by changing the default parameter values in the reloading providers.
Result
Logs/metrics emitted for reloading providers by default.
Test Plan
Adapted tests.