containertool: Allow destination repository to be set by an environment variable #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
force-pushed
the
repository-environment-variable
branch
2 times, most recently
from
14c35ad to
1d2703d
Compare
euanh
added
kind/enhancement
euanh
force-pushed
the
repository-environment-variable
branch
from
1d2703d to
19481e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It is currently only possible to set the destination repository by specifying the mandatory
--repositoryflag. Setting the repository from an environment variable can be more convenient in scripts and in the terminal - the destination repository can be set once and inherited by all further builds in the same shell.Modifications
--repositoryis no longer a mandatory argument.CONTAINERTOOL_REPOSITORYenvironment variable is used if--repositoryis not set.Fixes #100
Result
Either
--repositoryorCONTAINERTOOL_REPOSITORYcan be used to define the destination repository. The command line flag takes precedence over the environment variable.Test Plan
All existing tests continue to pass.