ci: Enable smoke tests #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
force-pushed
the
ci-enable-integration-tests
branch
3 times, most recently
from
4c53b60 to
713927e
Compare
euanh
force-pushed
the
ci-enable-integration-tests
branch
from
713927e to
65a9c50
Compare
These integration tests require an instance of the container registry to be available.
euanh
force-pushed
the
ci-enable-integration-tests
branch
from
65a9c50 to
938fd0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The integration tests (
SmokeTests) are not currently run on PRs because they require an instance of the container registry to be available.Modifications
Add a custom job which runs
registryas a service container.Result
Integration tests will be run for every pull request. The integration test job also runs the tests run by the unit tests job, but the duplication is not very costly.
Test Plan
All tests continue to pass.