ContainerRegistry: Reject invalid repository names #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
force-pushed
the
135-registry-name-checks
branch
from
00338d0 to
a685f2e
Compare
euanh
force-pushed
the
135-registry-name-checks
branch
2 times, most recently
from
989fd23 to
8f19b3b
Compare
euanh
changed the title
euanh
force-pushed
the
135-registry-name-checks
branch
3 times, most recently
from
c8ef624 to
1e30ef9
Compare
euanh
force-pushed
the
135-registry-name-checks
branch
3 times, most recently
from
a894e29 to
e90b537
Compare
euanh
force-pushed
the
135-registry-name-checks
branch
from
e90b537 to
91e9988
Compare
euanh
force-pushed
the
135-registry-name-checks
branch
from
5c067e0 to
4f4b735
Compare
euanh
added a commit
to euanh/swift-container-plugin
that referenced
this pull request
Jul 1, 2025
Motivation ---------- `ImageReference` does not check for illegal characters in parsed image references. This means that `containertool` will send illegal image names to the registry. The registry will reject them, but the error message might not explain why, so a generic error message will be printed. Runtimes reject illegal image references immediately, without sending them to the registry. Modifications ------------- * Introduce a `Repository` wrapper type * Check validity when constructing the `Repository` * Change the low-level API functions to accept `Repository` instead of `String`. Result ------ It is impossible to create a `Repository` object containing a malformed name, because the constructor checks the string value. It is impossible to send a malformed name to the registry because the API wrappers only accept `Repository` objects. Fixes apple#135 Test Plan --------- Existing tests continue to pass. New tests exercise additional checks which were previously missing.
euanh
added a commit
that referenced
this pull request
Jul 1, 2025
Motivation ---------- Cherry pick of #138. `ImageReference` does not check for illegal characters in parsed image references. This means that `containertool` will send illegal image names to the registry. The registry will reject them, but the error message might not explain why, so a generic error message will be printed. Runtimes reject illegal image references immediately, without sending them to the registry. Modifications ------------- * Introduce a `Repository` wrapper type * Check validity when constructing the `Repository` * Change the low-level API functions to accept `Repository` instead of `String`. Result ------ It is impossible to create a `Repository` object containing a malformed name, because the constructor checks the string value. It is impossible to send a malformed name to the registry because the API wrappers only accept `Repository` objects. Fixes #135 Test Plan --------- Existing tests continue to pass. New tests exercise additional checks which were previously missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ImageReferencedoes not check for illegal characters in parsed image references. This means thatcontainertoolwill send illegal image names to the registry. The registry will reject them, but the error message might not explain why, so a generic error message will be printed. Runtimes reject illegal image references immediately, without sending them to the registry.Modifications
Repositorywrapper typeRepositoryRepositoryinstead ofString.Result
It is impossible to create a
Repositoryobject containing a malformed name, because the constructor checks the string value. It is impossible to send a malformed name to the registry because the API wrappers only acceptRepositoryobjects.Fixes #135
Test Plan
Existing tests continue to pass.
New tests exercise additional checks which were previously missing.