containertool: Use the default registry parameter for image uploads #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
--default-registryparameter (also set by theCONTAINERTOOL_DEFAULT_REGISTRYenvironment variable) allows a default registry address to be specified for unqualified image names. For example, the following uploads should be equivalent:containertool --default-registry myregistry.com --repository myrepo/myimage --from baserepo/baseimagecontainertool --repository myregistry.com/myrepo/myimage --from baserepo/baseimageHowever the default registry was only being applied when fetching the base image (the
--fromparameter) and not when pushing the final image (the--repositoryparameter).Modifications
The default registry parameter is now used when pushing the final image.
Result
Pushes to unqualified repositories will work properly.
Test Plan
Manually tested
containertooluploads with a variety of qualified and unqualified image names.