ContainerRegistry: Tolerate missing Content-Type header in registry response #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
added
semver/minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ECR does not set the
Content-Typeheader in its response to a blob upload. If it is not present, the HTTP standard allows clients to guess the content type, or default to `application/octet-stream'. In this case, knowing the content type is not critical so there is no need to check for it.Modifications
Do not check that responses contain the
Content-Typeheader in the low-level HTTP client.Result
Blob uploads to ECR will not fail.
Test Plan
Automated tests continue to pass; tested manually with ECR.