Examples: Use plugin release 0.2.0 and remove Package.resolved #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
added
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release 0.1.0 timed out when uploading to Docker Hub and ECR (#17), so the examples should not allow it to be used.
At the time of the initial release, the examples also needed some dependencies to be pinned to the newest versions to avoid compilation problems with Swift 6.0 or the static Linux SDK. These problems have now been fixed upstream, so any new build should succeed.
Furthermore, as time goes on, pinning dependencies means that any new compilation problems arising upstream are hidden. Removing
Package.resolvedmeans that each clean build will use the newest available dependencies, so new problems upstream will be highlighted.Modifications
For each example:
Update
Package.swiftto use the new plugin release.Remove
Package.resolved.Result
It should be possible to build and publish the examples to Docker Hub or ECR.
Test Plan
Automated tests still pass; also tested manually with several registries.