ContainerRegistry: Unconditionally depend on swift-crypto #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
force-pushed
the
unconditionally-depend-on-swift-crypto
branch
3 times, most recently
from
3c97a82 to
84d41a0
Compare
euanh
force-pushed
the
unconditionally-depend-on-swift-crypto
branch
from
84d41a0 to
7912182
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
swift-cryptoprovides a common cryptography interface on macOS and Linux. On macOS it defers to CryptoKit, and although the files in the library must all be processed the compilation time is minimal.In the past, on slower machines, avoiding processing
swift-cryptoon macOS seemed to improve build times by a few seconds. Currently the cost of processing these files is negligible, and usingswift-cryptoon Linux and macOS allows conditional includes to be removed.Modifications
Always depend on
swift-cryptoinPackage.swiftReplace conditional imports of
CryptoKitwith unconditional imports ofCrypto.Result
No functional change.
Test Plan
Automated tests continue to pass.