Skip to content

Conversation

@euanh
Copy link
Collaborator

@euanh euanh commented Dec 6, 2024

Motivation

It is very important that the example projects work when a new user tries them, but upstream changes might cause them to stop working even if nothing changes in this project. This PR adds a job to run the tests daily to identify such problems as early as possible.

Modifications

  • Extract the end to end tests into a reusable workflow
  • Add a new action to run the tests daily, and for every push to main

Result

Tests will be run periodically.

Test Plan

The existing tests continue to pass - this PR will run them more often.

@euanh euanh force-pushed the scheduled-endtoend-tests branch 5 times, most recently from 31de787 to 62533db Compare December 9, 2024 10:13
euanh added 2 commits December 9, 2024 10:17
This allows the same tests to be run by several actions.
@euanh euanh force-pushed the scheduled-endtoend-tests branch from 62533db to 4cc7869 Compare December 9, 2024 10:18
@euanh euanh changed the title wip: endtoend workflow tests: Test main daily Dec 9, 2024
@euanh euanh changed the title tests: Test main daily tests: Test main daily Dec 9, 2024
@euanh euanh marked this pull request as ready for review December 9, 2024 10:25
@euanh euanh merged commit 90642df into apple:main Dec 9, 2024
17 checks passed
@euanh euanh deleted the scheduled-endtoend-tests branch December 9, 2024 10:25
@euanh euanh added semver/none No version bump required. area/testing Improvements to tests. labels Dec 9, 2024
@euanh euanh linked an issue Dec 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/testing Improvements to tests. semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

End to end tests should be run nightly

1 participant