Use v5 language mode for containertool #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nightly mainline compiler used by the pull request checks objects to the way containertool uses stderr. Switch to language mode 5 until this can be rewritten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The containertool target will not build with the
nightlyLinux image currently being used for some of the CI tests. Falling back to Swift Language Mode v5 allows all tests to be enabled.Modifications
The containertool target is declared to use the v5 language mode.
The
api_breakage_checktest is enabled.Result
containertoolwill build using Linux images, and the breakage checks will run.Test Plan
Built locally and verified that the new tests pass using
act pull_request.