ci: Use a shared definition of integration tests in pull request and main jobs #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
changed the title
euanh
force-pushed
the
ci-interop-on-main
branch
from
edf7b49 to
1cf32e1
Compare
euanh
changed the title
euanh
added
semver/none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The definition of the integration test job was duplicated in
main.ymlandpull_request.yml. When changes were made in one but not the other, the pull request CI job passed but the main CI job later failed after the pull request had been merged.Modifications
main.ymlandpull_request.ymlcan both include.Result
If the pull request job succeeds, the main job should also succeed.
Test Plan
Tests on main branch pass again.